Yair Zaslavsky has posted comments on this change. Change subject: core: requiring permissions to manage tags, bookmarks and notifications ......................................................................
Patch Set 2: (1 comment) Just one question to be sure.. Besides that the code looks good. .................................................... File packaging/dbscripts/upgrade/03_04_0320_add_admin_operations_action_groups_and_roles.sql Line 31: FROM roles Line 32: WHERE id = v_TAG_MANAGER_ROLE_ID); Line 33: Line 34: INSERT INTO roles_groups values(v_TAG_MANAGER_ROLE_ID, 1301); Line 35: INSERT INTO roles_groups values(v_TAG_MANAGER_ROLE_ID, 1300); Just to make sure - we want tag manager to log in? My question is valid for the other manager roles you introduced.. Line 36: Line 37: -- Adding the BookmarkManager role Line 38: DELETE FROM roles_groups WHERE role_id = v_BOOKMARK_MANAGER_ROLE_ID; Line 39: -- To view, visit http://gerrit.ovirt.org/22731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I477bca5703f59c67914e6395118e29d53fa7d007 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
