Moti Asayag has posted comments on this change. Change subject: core: Scheduling Jobs with Configurable Delay ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java Line 74: ConfigValues.AsyncTaskPollingRate.toString(), TimeUnit.SECONDS); Since you intend to resolve the property by its name, you should be aligned between this value to the property name as defined in the enum itself, The resolution of the enum is done by "ConfigValues.valueof(enumName). If the name doesn't match, an exception will be thrown. By setting the ConfigValues.AsyncTaskPollingRate.toString() with the toString() - you're at some risk since this method can be overridden, however, by using the final method ConfigValues.AsyncTaskPollingRate.name() code is safer. Please replace the toString() with name() around this patch. -- To view, visit http://gerrit.ovirt.org/3829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b0d35de9d1a29712e058892df50c49f72027686 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
