Moti Asayag has uploaded a new change for review. Change subject: engine: Change DetachNetworkToVdsGroup to non-transactive ......................................................................
engine: Change DetachNetworkToVdsGroup to non-transactive The command will be used also for removing the network from the hostis. For that purpose the command should be managed as a non-transactive. Change-Id: I419ddbd3b657dae7829f15d45399b3b1a4996172 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/22769/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java index 61bbc45..102b0f0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java @@ -4,6 +4,7 @@ import java.util.Collections; import java.util.List; +import org.ovirt.engine.core.bll.NonTransactiveCommandAttribute; import org.ovirt.engine.core.bll.ValidationResult; import org.ovirt.engine.core.bll.VdsGroupCommandBase; import org.ovirt.engine.core.bll.utils.PermissionSubject; @@ -17,16 +18,26 @@ import org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface; import org.ovirt.engine.core.common.errors.VdcBllMessages; import org.ovirt.engine.core.compat.Guid; +import org.ovirt.engine.core.utils.transaction.TransactionMethod; +import org.ovirt.engine.core.utils.transaction.TransactionSupport; -public class DetachNetworkToVdsGroupCommand<T extends AttachNetworkToVdsGroupParameter> extends - VdsGroupCommandBase<T> { +@NonTransactiveCommandAttribute +public class DetachNetworkToVdsGroupCommand<T extends AttachNetworkToVdsGroupParameter> extends VdsGroupCommandBase<T> { public DetachNetworkToVdsGroupCommand(T parameters) { super(parameters); } @Override protected void executeCommand() { - getNetworkClusterDAO().remove(getParameters().getVdsGroupId(), getParameters().getNetwork().getId()); + TransactionSupport.executeInNewTransaction(new TransactionMethod<Void>() { + + @Override + public Void runInTransaction() { + getNetworkClusterDAO().remove(getParameters().getVdsGroupId(), getParameters().getNetwork().getId()); + return null; + } + }); + setSucceeded(true); } -- To view, visit http://gerrit.ovirt.org/22769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I419ddbd3b657dae7829f15d45399b3b1a4996172 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
