Itamar Heim has posted comments on this change.

Change subject: core: search VM & Template by object id
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
Line 37:         mVerbs.put("_VM_ID", "_VM_ID");
i'd add a comment above this line:
// putting this after buildCompeletions() so it will not be visible/included in 
the autoComplete for users.

....................................................
File 
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java
Line 24:         mVerbs.put("_VMT_ID", "_VMT_ID");
same

--
To view, visit http://gerrit.ovirt.org/4159
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8ac31d8a20ff83a8a58afa73f8d080c512ad8db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to