Alissa Bonas has uploaded a new change for review. Change subject: ui: fix findbugs warning in AbstractSubTabActionTree. ......................................................................
ui: fix findbugs warning in AbstractSubTabActionTree. Warning of type RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE was produced because the 'tree' class member is always null, hence this code is never be executed. Change-Id: I7dfe0048c53675bf0e25fc52091601c3d667060e Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/22807/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java index 077ad3c..91e9ec5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java @@ -78,9 +78,8 @@ }); actionPanel = createActionPanel(modelProvider); - if (actionPanel != null && tree != null) { + if (actionPanel != null) { actionPanelContainer.add(actionPanel); - actionPanel.addContextMenuHandler(tree); } updateStyles(); -- To view, visit http://gerrit.ovirt.org/22807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7dfe0048c53675bf0e25fc52091601c3d667060e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
