Allon Mureinik has posted comments on this change.
Change subject: core: introduce customized snapshot preview support
......................................................................
Patch Set 5: Code-Review-1
(3 comments)
The test should be introduced together with the query.
Other than that, nits.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsFromConfigurationByVmIdQuery.java
Line 32: }
Line 33:
Line 34: public VM getVmConfigurationBySnapshot(Guid snapshotId) {
Line 35: VdcQueryReturnValue queryReturnValue =
Line 36:
Backend.getInstance().runInternalQuery(VdcQueryType.GetVmConfigurationBySnapshot,
s/Backedn.getInstance()/getBackend()/
Line 37: new IdQueryParameters(snapshotId));
Line 38:
Line 39: VM vm = null;
Line 40: if (queryReturnValue.getSucceeded()) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 735: /**
Line 736: * Returns the intersection set of the specified image lists
(based on images' IDs)
Line 737: * @param images1 1st list
Line 738: * @param images2 2nd list
Line 739: * @return
Don't leave this empty.
Line 740: */
Line 741: public static List<DiskImage> imagesIntersection(List<DiskImage>
images1, List<DiskImage> images2) {
Line 742: List<DiskImage> intersection = new ArrayList<>();
Line 743: for (DiskImage image : images1) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java
Line 2:
Line 3: import org.ovirt.engine.core.common.businessentities.DiskImage;
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5:
Line 6: import java.util.List;
This should be on top
Line 7:
Line 8: public class TryBackToAllSnapshotsOfVmParameters extends
VmOperationParameterBase implements java.io.Serializable {
Line 9: private static final long serialVersionUID = 1862924807826485840L;
Line 10: private Guid dstSnapshotId;
--
To view, visit http://gerrit.ovirt.org/22776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89332a1538c7259dd3ea62d693ac062f47e52cd0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
