Mike Kolesnik has posted comments on this change.
Change subject: core: Added QoS overridden member to VdsNetworkInterface
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
I think you can't forfeit the "unsynced" concept just because you allow the
user to override the QoS on a single NIC level.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
Line 328: this.networkImplementationDetails =
networkImplementationDetails;
Line 329: }
Line 330:
Line 331: /**
Line 332: * Gets the QoS configured on this interface, which overrides the
one possibly configured on the network.
How will you know that the applied QoS is the same as the intended QoS if
you're using the same field?
Line 333: */
Line 334: public NetworkQoS getQos() {
Line 335: return qos;
Line 336: }
--
To view, visit http://gerrit.ovirt.org/22764
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffc4c2f5b35ed34bf64e4d892a0e9ed64f94bde
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
