Greg Sheremeta has posted comments on this change.
Change subject: userportal, webadmin: ScrollableTabBar
......................................................................
Patch Set 5: Verified+1 Code-Review+1
(3 comments)
Impressive patch!
I also ran it, worked well.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
Line 166: private Widget copyWidget(final IsWidget widget) {
Line 167: HTML newWidget = null;
Line 168: if (widget != null) {
Line 169: newWidget = new HTML();
Line 170: // widget.asWidget().addStyleName(style.dropdownItems());
strays
Line 171: // Align the text of the copy left, so it shows properly
in the list.
Line 172: //
widget.asWidget().getElement().getStyle().setProperty(TEXT_ALIGN, "left");
//$NON-NLS-1$
Line 173:
newWidget.setHTML(widget.asWidget().getElement().getString().replaceAll("class=\".*?\"",
//$NON-NLS-1$
Line 174: "class=\"" + style.dropdownItems() + "\""));
//$NON-NLS-1$ //$NON-NLS-2$
Line 181: adjustButtons();
Line 182: }
Line 183: });
Line 184: newWidget.addStyleName(style.dropdownItemContainer());
Line 185: // Remove the extra styles from the original widget now
that we have a copy of it.
strays
Line 186: //
widget.asWidget().getElement().getStyle().clearProperty(TEXT_ALIGN);
Line 187: //
widget.asWidget().removeStyleName(style.dropdownItems());
Line 188: }
Line 189: return newWidget;
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/RepeatingPushButton.java
Line 2:
Line 3: import com.google.gwt.user.client.Timer;
Line 4: import com.google.gwt.user.client.ui.PushButton;
Line 5:
Line 6: public class RepeatingPushButton extends PushButton {
very neat.
Line 7: /**
Line 8: * The repeating period, in milliseconds.
Line 9: */
Line 10: private int period;
--
To view, visit http://gerrit.ovirt.org/21716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63dddb3c0026ea3a5c13c3d18daebd02e13b1043
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
