Yedidyah Bar David has posted comments on this change. Change subject: packaging: fixed issues with setup logic ......................................................................
Patch Set 3: Verified-1 (1 comment) Not sure we really need this change now anyway .................................................... File packaging/common_utils.py Line 736: if ( Line 737: db_dict['username'] == 'admin' and Line 738: db_dict['password'] == 'dummy' Line 739: ): Line 740: if localHost(db_dict['host']): If we do not enter this 'if', rc will not be initialized and fail below. Line 741: output, rc = runPostgresSuQuery( Line 742: query='"select 1;"', Line 743: database=db_dict['dbname'], Line 744: failOnError=False, -- To view, visit http://gerrit.ovirt.org/22708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35be9a7bbf46ff99885d8ade800fcaa8706aa44f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
