Allon Mureinik has posted comments on this change.
Change subject: core: [db] squash 3.1 upgrade scripts
......................................................................
Patch Set 1: Code-Review+1
(5 comments)
Out of interest - did you bench mark how much faster creating a 3.3 schema is
after this patch?
....................................................
File packaging/dbscripts/insert_data.sql
Line 20: values
('03020000','upgrade/03_02_0000_set_version.sql','0','engine',now(),'INSTALLED',true);
Line 21:
Line 22: -- INSERT everyone TO ad_groups
Line 23: INSERT into ad_groups (id,name,status,domain,distinguishedname)
Line 24: SELECT getGlobalIds('everyone'),
the case change seems unrelated to this patch, which is big and scary enough as
is.
I'd omit it.
Line 25: 'Everyone',
Line 26: 1,
Line 27: '',
Line 28: ''
Line 26: 1,
Line 27: '',
Line 28: ''
Line 29: where not exists (
Line 30: SELECT id from ad_groups where id = getGlobalIds('everyone'));
here too
Line 31:
Line 32: --INSERTING DATA INTO TABLE storage_pool
Line 33:
Line 34: INSERT INTO storage_pool
(id,name,description,storage_pool_type,status,master_domain_version,compatibility_version)
SELECT v_storage_pool_id,'Default','The default Data Center',1,0,0,'3.3';
Line 43:
Line 44: INSERT INTO vm_static (vm_guid, vm_name, mem_size_mb, vmt_guid, os,
description, vds_group_id, domain, creation_date, num_of_monitors,
is_initialized, is_auto_suspend, num_of_sockets, cpu_per_socket, usb_policy,
time_zone, is_stateless, fail_back, _create_date, _update_date,
dedicated_vm_for_vds, auto_startup, vm_type, nice_level, default_boot_sequence,
default_display_type, priority, iso_path, origin, initrd_url, kernel_url,
kernel_params, migration_support, userdefined_properties,
predefined_properties, min_allocated_mem, entity_type, child_count,
template_status, quota_id, allow_console_reconnect, cpu_pinning,
is_smartcard_enabled) VALUES ('00000000-0000-0000-0000-000000000000', 'Blank',
1024, '00000000-0000-0000-0000-000000000000', 0, 'Blank template',
'00000001-0001-0001-0001-000000000001', '', '2008-04-01 00:00:00+03', 1, NULL,
false, 1, 1, 1, NULL, NULL, false, '2013-12-25 15:31:54.367179+02', '2013-12-25
15:31:53.239308+02', NULL, NULL, 0, 0, 0, 0, 0, '', 0,!
NULL, NULL, NULL, 0, NULL, NULL, 0, 'TEMPLATE', 0, 0, NULL, false, NULL,
false);
Line 45:
Line 46:
Line 47: INSERT INTO event_map(event_up_name, event_down_name)
values('VDC_STOP', 'VDC_START');
same comment about changing cases for all of these...
Line 48:
Line 49: INSERT INTO event_map(event_up_name, event_down_name)
values('IRS_FAILURE', 'UNASSIGNED');
Line 50: INSERT INTO event_map(event_up_name, event_down_name)
values('IRS_DISK_SPACE_LOW', 'UNASSIGNED');
Line 51: INSERT INTO event_map(event_up_name, event_down_name)
values('IRS_DISK_SPACE_LOW_ERROR', 'UNASSIGNED');
Line 121: Insert into dwh_history_timekeeping
VALUES('lastSync',NULL,to_timestamp('01/01/2000', 'DD/MM/YYYY'));
Line 122: RETURN;
Line 123: END; $procedure$
Line 124: LANGUAGE plpgsql;
Line 125: SELECT insert_data();
and this one too.
Line 126: drop function insert_data();
Line 127:
Line 128:
Line 129:
/******************************************************************************************************
....................................................
File packaging/dbscripts/insert_predefined_roles.sql
Line 1: Create or replace FUNCTION insert_predefined_roles()
Line 2: RETURNS VOID
Line 3: AS $procedure$
Line 4: DECLARE
I /strongly/ disagree.
I love the formatting change, but why introduce even more noise to a 4K lines
patch?
This would be better served as a separate patch.
Line 5: --Roles
Line 6: v_SUPER_USER_ID UUID;
Line 7: v_POWER_USER_ID UUID;
Line 8: v_USER_ID UUID;
--
To view, visit http://gerrit.ovirt.org/22817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a821e9308b9c30bf1087c9509eefa880fc92492
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
