Mike Kolesnik has posted comments on this change.
Change subject: engine: Add Label and Unlabel network commands
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UnlabelNetworkCommand.java
Line 55: return getSucceeded() ? AuditLogType.UNLABEL_NETWORK :
AuditLogType.UNLABEL_NETWORK_FAILED;
Line 56: }
Line 57:
Line 58: @Override
Line 59: protected List<Class<?>> getValidationGroups() {
This isn't necessary as you don't have validations happening only for
UpdateEntity group
Line 60: addValidationGroup(UpdateEntity.class);
Line 61: return super.getValidationGroups();
Line 62: }
Line 63:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 93: UpdateVnicProfile(161, ActionGroup.CONFIGURE_NETWORK_VNIC_PROFILE,
false, QuotaDependency.NONE),
Line 94: RemoveVnicProfile(162, ActionGroup.DELETE_NETWORK_VNIC_PROFILE,
false, QuotaDependency.NONE),
Line 95:
Line 96: // Netowrk labels
Line 97: LabelNetwork(162, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK,
false, QuotaDependency.NONE),
162 is already taken by RemoveVnicProfile
Line 98: UnlabelNetwork(163, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK,
false, QuotaDependency.NONE),
Line 99:
Line 100: // VmTemplatesCommand
Line 101: AddVmTemplate(201, ActionGroup.CREATE_TEMPLATE,
QuotaDependency.BOTH),
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1303:
Line 1304: @DefaultStringValue("The specified external network cannot be
configured on the host's interface.")
Line 1305: String EXTERNAL_NETWORK_CANNOT_BE_PROVISIONED();
Line 1306:
Line 1307: @DefaultStringValue("Network label must be formed only from:
English letters, numbers, hyphen or underscor3yye.")
I think you left here something by mistake
Line 1308: String NETWORK_LABEL_FORMAT_INVALID();
Line 1309:
Line 1310: @DefaultStringValue("Cannot ${action} ${type}. The specified
network is already labeled.")
Line 1311: String ACTION_TYPE_FAILED_NETWORK_ALREADY_LABELED();
--
To view, visit http://gerrit.ovirt.org/22801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2064d24f0d357ca8d477266e4a9e18939bf21ad0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
