Mike Kolesnik has posted comments on this change.
Change subject: engine: Configure network on hosts on cluster assignment
......................................................................
Patch Set 5:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java
Line 34:
Line 35: for (VdsNetworkInterface nic : nics) {
Line 36: SetupNetworksParameters setupNetworkParams =
createSetupNetworksParameters(nic.getVdsId());
Line 37: VdsNetworkInterface nicToConfigure =
getNicToConfigure(setupNetworkParams.getInterfaces(), nic.getId());
Line 38: if (nicToConfigure == null) {
Not sure how this is possible if you always send the NICs that have the label..
Line 39: continue;
Line 40: }
Line 41:
Line 42: if (vlanNetwork) {
Line 38: if (nicToConfigure == null) {
Line 39: continue;
Line 40: }
Line 41:
Line 42: if (vlanNetwork) {
What if a VM network is already attached to the NIC? This would definitely fail
so it would make sense to report it also.
Line 43: VdsNetworkInterface vlan =
createVlanDevice(nic.getName(), nicToConfigure.getVdsId(), network);
Line 44: setupNetworkParams.getInterfaces().add(vlan);
Line 45: } else if (nicToConfigure.getNetworkName() == null) {
Line 46: nicToConfigure.setNetworkName(network.getName());
Line 41:
Line 42: if (vlanNetwork) {
Line 43: VdsNetworkInterface vlan =
createVlanDevice(nic.getName(), nicToConfigure.getVdsId(), network);
Line 44: setupNetworkParams.getInterfaces().add(vlan);
Line 45: } else if (nicToConfigure.getNetworkName() == null) {
AFAIK the AttachNetwork command is called by UI also when updating attachemnt,
it's very likely that the interface would have the network already attached..
In this case it would be confusing to report it as non-updateable.
This should be handled either here, or preferably in UI to have it use the
UpdateNetworkOnCluster command.
Line 46: nicToConfigure.setNetworkName(network.getName());
Line 47: } else {
Line 48: // if a network is already assigned to that nic, it
cannot be configured
Line 49: nonUpdateableHosts.add(nic.getVdsId());
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 439: VDS_SET_NONOPERATIONAL_IFACE_DOWN=Host ${VdsName} moved to
Non-Operational state because interfaces '${Interfaces}' are down but are
needed by networks '${Networks}' in the current cluster
Line 440: BRIDGED_NETWORK_OVER_MULTIPLE_INTERFACES=Bridged network
${NetworkName} is attached to multiple interfaces: ${Interfaces} on Host
${VdsName}.
Line 441: NETWORK_WITHOUT_INTERFACES=Network ${NetworkName} is not attached to
any interface on host ${VdsName}.
Line 442: VNIC_PROFILE_UNSUPPORTED_FEATURES=VM ${VmName} has network interface
${NicName} which is using profile ${VnicProfile} with unsupported feature(s)
'${UnsupportedFeatures}' by VM cluster ${VdsGroupName} (version
${CompatibilityVersion}).
Line 443: ADD_NETWORK_BY_LABEL_FAILED=Network ${Network} cannot be configured
in data-center ${StoragePoolName} on the following hosts: ${HostNames}.
Perhaps "cannot be configured using the label"?
Line 444: PROVIDER_ADDED=Provider ${ProviderName} was added. (User: ${UserName})
Line 445: PROVIDER_ADDITION_FAILED=Failed to add provider ${ProviderName}.
(User: ${UserName})
Line 446: PROVIDER_UPDATED=Provider ${ProviderName} was updated. (User:
${UserName})
Line 447: PROVIDER_UPDATE_FAILED=Failed to update provider ${ProviderName}.
(User: ${UserName})
--
To view, visit http://gerrit.ovirt.org/22767
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ided511feab3a7addffcb1ddc559f32da6cb1873c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
