Lior Vernia has posted comments on this change.
Change subject: webadmin: Ability to add external subnet
......................................................................
Patch Set 1:
(5 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 3444: };
Line 3445:
Frontend.getInstance().runQuery(VdcQueryType.GetExternalSubnetsOnProviderByNetwork,
new IdQueryParameters(networkId), aQuery);
Line 3446: }
Line 3447:
Line 3448: public static List<IpVersion> getExternalSubnetIpVerionList() {
Fine by me.
Line 3449: return Arrays.asList(IpVersion.values());
Line 3450: }
Line 3451:
Line 3452: public static void getNumberOfActiveVmsInCluster(AsyncQuery
aQuery, Guid clusterId) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NewExternalSubnetModel.java
Line 24: public class NewExternalSubnetModel extends Model {
Line 25:
Line 26: private EntityModel<String> name;
Line 27: private EntityModel<String> cidr;
Line 28: private ListModel<NetworkView> network;
That's a good question. It's not necessary, but if it were up to me I'd add
some notion of the network whose subnet is being edited. I would use a
StringEntityModelLabelEditor in the view, which would require an
EntityModel<String> here for the network.
Line 29: private ListModel<IpVersion> ipVersion;
Line 30: private final EntityModel sourceModel;
Line 31: private ExternalSubnet subnet = null;
Line 32:
Line 38: setNetwork(new ListModel<NetworkView>());
Line 39: setIpVersion(new ListModel<IpVersion>());
Line 40:
getIpVersion().setItems(AsyncDataProvider.getExternalSubnetIpVerionList());
Line 41:
Line 42:
setTitle(ConstantsManager.getInstance().getConstants().externalSubnetTitle());
Here the title is actually used as the title of the dialog, so shouldn't be
removed. It's just for tabs that it isn't used.
Line 43: setHashName("new_external_subnet"); //$NON-NLS-1$
Line 44:
Line 45: initCommands();
Line 46: }
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
Line 463: @DefaultStringValue("VNIC Profiles")
Line 464: String vnicProfilesTitle();
Line 465:
Line 466: @DefaultStringValue("External Subnet")
Line 467: String externalSubnetTitle();
This should be re-added as per my comment on dialog model titles.
Line 468:
Line 469: @DefaultStringValue("External Subnets")
Line 470: String externalSubnetsTitle();
Line 471:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.java
Line 51: protected ListModelListBoxEditor<IpVersion> ipVersionEditor;
Line 52:
Line 53: @UiField(provided = true)
Line 54: @Path("network.selectedItem")
Line 55: ListModelListBoxEditor<Object> networkEditor;
If you decide to follow my suggestion, this should be
StringEntityModelLabelEditor, with path "network.entity".
Line 56:
Line 57: private final Driver driver = GWT.create(Driver.class);
Line 58:
Line 59: @Inject
--
To view, visit http://gerrit.ovirt.org/22689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7315f9ffe29f72d06deb56dcd637c53fba47b116
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
