Mike Kolesnik has posted comments on this change.
Change subject: engine: Update network on hosts when label is changed
......................................................................
Patch Set 5:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
Line 340: VdsNetworkInterface nic =
hostToNic.get(labeledNic.getVdsId());
Line 341:
Line 342: // sync the network if not labeled
Line 343: if (nic == null) {
Line 344: nicsForSync.add(nic);
How do you intend to sync a null nic?
Line 345: } else {
Line 346: // remove the network from labeled nic
Line 347: nicsForRemove.add(labeledNic);
Line 348: }
Line 393: }
Line 394: return labeledNics;
Line 395: }
Line 396:
Line 397: private void
createSyncNetworkParameters(ArrayList<VdcActionParametersBase> parameters,
Kind of messy that you alter the collection in place..
Line 398: Collection<VdsNetworkInterface> nics) {
Line 399:
Line 400: Set<Guid> hostIdsToSync = new HashSet<>();
Line 401: for (VdsNetworkInterface nic : nics) {
--
To view, visit http://gerrit.ovirt.org/22772
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b851d589db8ad6ef025d3b752c9596aa30aee2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
