Daniel Erez has uploaded a new change for review. Change subject: core: disk migrate - avoid ctr init on last task handler ......................................................................
core: disk migrate - avoid ctr init on last task handler LiveMigrateDiskCommand - avoid initialization on constructor in case of last task handler: * No need to fetch un-needed stale data after last task completion. * Prevent an NPE on getVm() -> getVmsListForDisk() [as getImageGroupId() can be null in case of deleting the source disk before the last task (deleteImage) has been completed]. Change-Id: I4c8f14fdcc5e7db3cca41d2ce2e37e97a034ca23 Bug-Url: https://bugzilla.redhat.com/971022 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/22882/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java index 0184190..3c4a0fa 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java @@ -32,6 +32,12 @@ public LiveMigrateDiskCommand(T parameters) { super(parameters); + if (isLastTaskHandler()) { + // No need to initialize values if all tasks have been completed + // (prevent fetching un-needed/stale data after last task completion) + return; + } + setStoragePoolId(getVm().getStoragePoolId()); getParameters().setStoragePoolId(getStoragePoolId()); -- To view, visit http://gerrit.ovirt.org/22882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c8f14fdcc5e7db3cca41d2ce2e37e97a034ca23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
