Juan Hernandez has submitted this change and it was merged. Change subject: Revert "cli: mismatch between restore snapshot syntax and auto completion #1027298" ......................................................................
Revert "cli: mismatch between restore snapshot syntax and auto completion #1027298" This reverts commit 870b0c as it introduces a regression: moving the options to the end of the command moves them past the redirections and pipes, and this causes a syntax error. This is the bug that the change intended to fix: https://bugzilla.redhat.com/1047513 A later patch introduces changes in the syntax of commands allowing mixing arguments and options. That fixes the above bug as well as the regression. Change-Id: I7b85120e6479c4be3dd2357ef8731cd1388b8885 Bug-Url: https://bugzilla.redhat.com/1047513 Signed-off-by: Juan Hernandez <[email protected]> --- M src/ovirtcli/infrastructure/historymanager.py M src/ovirtcli/shell/actioncmdshell.py M src/ovirtcli/shell/engineshell.py 3 files changed, 4 insertions(+), 86 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b85120e6479c4be3dd2357ef8731cd1388b8885 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
