Mike Kolesnik has posted comments on this change.
Change subject: core: Validate only supported nics are labeled
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
Line 41:
context.buildConstraintViolationWithTemplate("SLAVE_INTERFACE_IS_MISCONFIGURED").addConstraintViolation();
Line 42: return false;
Line 43: }
Line 44:
Line 45: if (validateLabel(iface)) {
You meant to negate the condition?
Line 46: context.disableDefaultConstraintViolation();
Line 47:
context.buildConstraintViolationWithTemplate("IMPROPER_INTERFACE_IS_LABELED").addConstraintViolation();
Line 48: }
Line 49:
--
To view, visit http://gerrit.ovirt.org/22868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id510dd0ae8f24533aaf7b6760e6188d2e036b312
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
