Eli Mesika has posted comments on this change.
Change subject: codegen: Remove the hardcoded root URL
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java
Line 213: // additional leading slash:
Line 214: url = dl.getHref().replace(rootUrl, "");
Line 215: while (url.startsWith(SLASH)) {
Line 216: url = url.substring(SLASH.length());
Line 217: }
wouldn't that be easier with Regex ???
Line 218:
Line 219: rel = dl.getRel();
Line 220: requestBodyType = dl.getRequest().getBody().getType();
Line 221: requestMethod = dl.getRequest().getHttpMethod();
--
To view, visit http://gerrit.ovirt.org/22552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77a63f8d3ad4d5fa759703be0857fac8e9b50da2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
