Mike Kolesnik has posted comments on this change.
Change subject: engine: Retrieve networks by label for a cluster
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
Line 118: }
Line 119:
Line 120: @Override
Line 121: public List<Network> getAllByLabelForCluster(String label, Guid
clusterId) {
Line 122: List<Network> networksInCluster = getAllForCluster(clusterId,
null, false);
Why not call just with id?
Line 123: List<Network> labeledNetworks = new ArrayList<>();
Line 124: for (Network network : networksInCluster) {
Line 125: if (StringUtils.equals(network.getLabel(), label)) {
Line 126: labeledNetworks.add(network);
--
To view, visit http://gerrit.ovirt.org/22890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibffa2222669a42541cb2da80430d86c8aaddd471
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
