Alon Bar-Lev has posted comments on this change. Change subject: asd ......................................................................
Patch Set 1: (13 comments) you must split out this patch into smaller changes which for specific issue and after code is ready to apply the snmp patch. .................................................... File backend/manager/dependencies/pom.xml Line 439 Line 440 Line 441 Line 442 Line 443 please add it also here Line 227: Line 228: <dependency> Line 229: <groupId>org.snmp4j</groupId> Line 230: <artifactId>snmp4j</artifactId> Line 231: <version>2.2.2</version> please put variable for version Line 232: </dependency> Line 233: Line 234: </dependencies> Line 235: .................................................... File backend/manager/dependencies/src/main/modules/org/snmp4j/main/module.xml Line 9: <!--<dependencies>--> Line 10: <!--<module name="javax.api"/>--> Line 11: <!--<module name="org.slf4j"/>--> Line 12: <!--<module name="com.mchange.c3p0"/>--> Line 13: <!--</dependencies>--> why commented? Line 14: .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java these kind of changes should be in separate patch. Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import java.util.Collections; Line 4: import java.util.List; .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveEventSubscriptionCommand.java these kind of changes should be in separate patch Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import java.util.ArrayList; Line 4: import java.util.List; .................................................... File backend/manager/tools/pom.xml Line 24: <name>snmp4j</name> Line 25: <url>https://oosnmp.net/dist/release/</url> Line 26: <snapshots> Line 27: <enabled>false</enabled> Line 28: </snapshots> isn't it the default? Line 29: </repository> Line 30: </repositories> Line 31: Line 32: <dependencies> Line 33: Line 34: <dependency> Line 35: <groupId>org.snmp4j</groupId> Line 36: <artifactId>snmp4j</artifactId> Line 37: <version>2.2.2</version> variable for version please Line 38: </dependency> Line 39: Line 40: <dependency> Line 41: <groupId>${engine.groupId}</groupId> .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationMethodsMapper.java Line 20 Line 21 Line 22 Line 23 Line 24 separate patch? .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java most probably should be in separate patch Line 1: package org.ovirt.engine.core.notifier; Line 2: Line 3: import java.net.ConnectException; Line 4: import java.sql.SQLException; .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationServiceException.java separate patch Line 1: package org.ovirt.engine.core.notifier; Line 2: Line 3: /** Line 4: * An exception of the notification service .................................................... File ovirt-engine.spec.in Line 207: Requires: springframework-instrument Line 208: Requires: springframework-jdbc Line 209: Requires: springframework-tx Line 210: Requires: xmlrpc-client Line 211: Requires: snmp4j tab please Line 212: %endif Line 213: %endif Line 214: Line 215: # We can't require exactly the same version and release of the Line 645: org/springframework/main/spring-jdbc.jar springframework/spring-jdbc.jar Line 646: org/springframework/main/spring-ldap-core.jar spring-ldap/spring-ldap-core.jar Line 647: org/springframework/main/spring-tx.jar springframework/spring-tx.jar Line 648: org/tukaani/xz/main/xz.jar Line 649: org/snmp4j/main/snmp4j.jar sort block please Line 650: %endif Line 651: %endif Line 652: __EOF__ Line 653: .................................................... File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in Line 43 Line 44 Line 45 Line 46 Line 47 ???? where does it come from? -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
