Juan Hernandez has posted comments on this change.
Change subject: core: Use new authentication interfaces
......................................................................
Patch Set 14: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/Manager.java
Line 263: throw new ConfigurationException(
Line 264: "Can't create object from configuration file \"" +
config.getFile().getAbsolutePath() + "\" becuase " +
Line 265: "it doesn't contain the mandatory parameter \"" +
config.getAbsoluteKey(NAME_PARAMETER) + "\"."
Line 266: );
Line 267: }
These changes should go in the patch that introduces the new interfaces.
Line 268:
Line 269: // Find the factory that supports the type:
Line 270: Factory<O> factory = findFactory(config);
Line 271: if (factory == null) {
--
To view, visit http://gerrit.ovirt.org/20412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5d6ee41b5373328eaf2f8448efe8e598609651
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
