Allon Mureinik has posted comments on this change. Change subject: core, engine: Prevent snapshot in ppc64 ......................................................................
Patch Set 4: Code-Review+1 Generally, +1 on the code. @Leonardo re your question about failed CDA - IMHO, if a request is made to take a snapshot with memory on a configuration that does not support it (e.g., oVirt 3.0 with any host architecture, oVirt 3.3 with PPC64), we should fail CDA. However, as you said, we ALREADY have this bug for x86, so I think it can be handled in a different patchset. @Arik/Omer - your thoughts? -- To view, visit http://gerrit.ovirt.org/21657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f201b63ddf441a9bc76a37fda33f54fa766d937 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: liron aravot <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
