Daniel Erez has posted comments on this change.
Change subject: webadmin: Set password auth field as default for reinstall
after installFailed
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java
Line 110: public EntityModel getInterfaceMappings() {
Line 111: return getNetworkProviderModel().getInterfaceMappings();
Line 112: }
Line 113:
Line 114: public void setVds(VDS v) {
s/v/value
Line 115: vds = v;
Line 116: }
Line 117:
Line 118: public VDS getVds() {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java
Line 156: @Override
Line 157: public void edit(final InstallModel model) {
Line 158: driver.edit(model);
Line 159:
Line 160: if (model.getVds().getStatus() == VDSStatus.InstallFailed) {
Consider the following refactor:
* boolean installedFailed = model.getVds().getStatus() ==
VDSStatus.InstallFailed;
* model.setAuthenticationMethod(installedFailed ? AuthenticationMethod.Password
: AuthenticationMethod.PublicKey);
* displayPasswordField(installedFailed);
* rbPassword.setValue(installedFailed);
* rbPublicKey.setValue(!installedFailed);
Line 161: rbPassword.setValue(true);
Line 162:
model.setAuthenticationMethod(AuthenticationMethod.Password);
Line 163: displayPasswordField(true);
Line 164: } else {
Line 170: rbPassword.addValueChangeHandler(new
ValueChangeHandler<Boolean>() {
Line 171: @Override
Line 172: public void onValueChange(ValueChangeEvent<Boolean>
event) {
Line 173:
model.setAuthenticationMethod(AuthenticationMethod.Password);
Line 174: displayPasswordField(true);
might conflict with: http://gerrit.ovirt.org/#/c/22924/
Line 175: }
Line 176: });
Line 177:
Line 178: rbPublicKey.addValueChangeHandler(new
ValueChangeHandler<Boolean>() {
--
To view, visit http://gerrit.ovirt.org/22919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I458e99a6351cd38d71a9949fb3044af5cfafd673
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
