Mike Kolesnik has posted comments on this change.
Change subject: engine: Command for adding external subnets
......................................................................
Patch Set 2:
(5 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddSubnetToProviderCommand.java
Line 19: import org.ovirt.engine.core.common.errors.VdcBllMessages;
Line 20: import org.ovirt.engine.core.compat.Guid;
Line 21:
Line 22: @NonTransactiveCommandAttribute
Line 23: public class AddSubnetToProviderCommand<T extends
AddExternalSubnetParameters> extends CommandBase<T> {
Great idea! I will do it in a follow up patch
Line 24:
Line 25: private Provider<?> provider;
Line 26:
Line 27: private ProviderNetwork externalNetwork;
Line 41:
Line 42:
Line 43: private ProviderNetwork getExternalNetwork() {
Line 44: if (externalNetwork == null) {
Line 45: Network network =
getNetworkDAO().get(getParameters().getNetworkId());
Done
Line 46: externalNetwork = network.getProvidedBy();
Line 47: }
Line 48:
Line 49: return externalNetwork;
Line 64: @Override
Line 65: protected boolean canDoAction() {
Line 66: ProviderValidator validator = new
ProviderValidator(getProvider());
Line 67:
Line 68: return validate(validator.providerIsSet()) &&
super.canDoAction();
Done
Line 69: }
Line 70:
Line 71: @Override
Line 72: protected void executeCommand() {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
Line 145: public void addSubnet(ExternalSubnet subnet) {
Line 146: com.woorea.openstack.quantum.model.Network externalNetwork =
getExternalNetwork(subnet.getExternalNetwork());
Line 147: SubnetForCreate subnetForCreate = new SubnetForCreate();
Line 148: subnetForCreate.setCidr(subnet.getCidr());
Line 149: subnetForCreate.setIpVersion(subnet.getIpVersion() ==
IpVersion.IPV6 ? 6 : 4);
This is translation specific for OpenStack Networking provider, not sure it's
relevant outside it..
Line 150: subnetForCreate.setName(subnet.getName());
Line 151: subnetForCreate.setNetworkId(externalNetwork.getId());
Line 152: subnetForCreate.setTenantId(externalNetwork.getTenantId());
Line 153:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 601: REMOVE_VNIC_PROFILE_FAILED(1127),
Line 602: NETWORK_WITHOUT_INTERFACES(1128),
Line 603: VNIC_PROFILE_UNSUPPORTED_FEATURES(1129,
AuditLogTimeInterval.DAY.getValue()),
Line 604: SUBNET_ADDED(1130),
Line 605: SUBNET_ADDITION_FAILED(1131),
Done
Line 606: SUBNET_REMOVED(1132),
Line 607: SUBNET_REMOVAL_FAILED(1133),
Line 608:
Line 609: // Import/Export
--
To view, visit http://gerrit.ovirt.org/22688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92ac30f46c1aa20677da34719fd33eec6b964899
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
