Allon Mureinik has posted comments on this change. Change subject: common: adding Affinity Groups business entity ......................................................................
Patch Set 8: Code-Review+1 (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java Line 186: if (other.entityNames != null) Line 187: return false; Line 188: } else if (!entityNames.equals(other.entityNames)) Line 189: return false; Line 190: return true; You can use ObjectUtils.equals to handle null fields in a simpler fashion. Line 191: } -- To view, visit http://gerrit.ovirt.org/22547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2be28b3a0aede953fcf09e1b6a8f8f99806d9fb5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
