mooli tayer has uploaded a new change for review. Change subject: tools: support remote jvm debugging in ovirt-engine-notifier ......................................................................
tools: support remote jvm debugging in ovirt-engine-notifier Change-Id: I7ecdd650763e00db1d85b36c3b6d2f48924e7935 Signed-off-by: Mooli Tayer <[email protected]> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py 2 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/22981/1 diff --git a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in index c835fcf..b6cc790 100644 --- a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in +++ b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in @@ -32,6 +32,12 @@ ENGINE_JAVA_MODULEPATH="${ENGINE_USR}/modules" # +# Use this if you want to enable remote debugging of the notifier java virtual +# machine (useful mainly for developers): +# +# NOTIFIER_DEBUG_ADDRESS=localhost:8686 + +# # Service timeouts # NOTIFIER_STOP_TIME=30 diff --git a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py index fa8bbd7..058859a 100755 --- a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py +++ b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py @@ -131,11 +131,27 @@ ) self._engineArgs = [ + # The name or the process, as displayed by ps: 'ovirt-engine-notifier', + '-Dlog4j.configuration=file://%s/notifier/log4j.xml' % ( self._config.get('ENGINE_ETC'), ), - '-Djboss.modules.write-indexes=false', + '-Djboss.modules.write-indexes=false' + ] + + debugAddress = self._config.get('NOTIFIER_DEBUG_ADDRESS') + if debugAddress: + self._engineArgs.append( + ( + '-agentlib:jdwp=transport=dt_socket,address=%s,' + 'server=y,suspend=n' + ) % ( + debugAddress + ) + ) + + self._engineArgs += [ '-jar', jbossModulesJar, '-dependencies', 'org.ovirt.engine.core.tools', '-class', 'org.ovirt.engine.core.notifier.Notifier', -- To view, visit http://gerrit.ovirt.org/22981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ecdd650763e00db1d85b36c3b6d2f48924e7935 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
