Mike Kolesnik has posted comments on this change.
Change subject: engine: Prevent removing a labeled network
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
Line 97:
Line 98: return translateViolations();
Line 99: }
Line 100:
Line 101: private void validateNotRemovingLabeledNetworks() {
Wouldn't this be problematic when detaching the network from cluster and this
code will run?
Line 102: Map<String, VdsNetworkInterface> nicsByName =
Entities.entitiesByName(params.getInterfaces());
Line 103: Map<String, VdsNetworkInterface> hostInterfacesByNetworkName =
Line 104:
Entities.hostInterfacesByNetworkName(getExistingIfaces().values());
Line 105:
--
To view, visit http://gerrit.ovirt.org/22941
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I300c0327fcf838b7581ad5a7ec12ee6bd9b9f0b2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
