Mike Kolesnik has posted comments on this change.
Change subject: engine: Add Label/Unlabel Nic commands
......................................................................
Patch Set 19:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnlabelNicCommand.java
Line 78:
Line 79: return nic;
Line 80: }
Line 81:
Line 82: public String getNickName() {
s/Nick/Nic/
Line 83: return getNic().getName();
Line 84: }
Line 85:
Line 86: public String getLabel() {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 480: EXTERNAL_NETWORK_CANNOT_BE_PROVISIONED(ErrorType.NOT_SUPPORTED),
Line 481: NETWORK_LABEL_FORMAT_INVALID(ErrorType.BAD_PARAMETERS),
Line 482: IMPROPER_INTERFACE_IS_LABELED(ErrorType.BAD_PARAMETERS),
Line 483: INTERFACE_ALREADY_LABELED(ErrorType.BAD_PARAMETERS),
Line 484: INTERFACE_NOT_LABELED(ErrorType.BAD_PARAMETERS),
Sounds to me like ErrorType.CONFLICT in both
Line 485:
ACTION_TYPE_FAILED_VNIC_PROFILE_NOT_EXISTS(ErrorType.BAD_PARAMETERS),
Line 486: ACTION_TYPE_FAILED_VNIC_PROFILE_NAME_IN_USE(ErrorType.CONFLICT),
Line 487: ACTION_TYPE_FAILED_VNIC_PROFILE_IN_USE(ErrorType.CONFLICT),
Line 488:
ACTION_TYPE_FAILED_CANNOT_FIND_VNIC_PROFILE_FOR_NETWORK(ErrorType.BAD_PARAMETERS),
--
To view, visit http://gerrit.ovirt.org/22870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73a76c66f4f4c1be2aa59952c50cc9829633d572
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
