Allon Mureinik has posted comments on this change. Change subject: core: Move VDS to Maintenance only if StopSPM is successful ......................................................................
Patch Set 1: (1 comment) .................................................... Commit Message Line 8: Line 9: Fixes MaintenanceNumberOfVdssCommand so only VDSs for which StopSPM was Line 10: executed successfully, will continues with Move to Maintenance process. Line 11: Line 12: Change-Id: I5a9a54b757d8aa5b5dc84ae02eae8114dfabc9f2 This generally is not the correct approach, and I'm surprised no-one caught on earlier. Change-Id should be unique PER BRANCH. When switching between branches it's customary to keep the change-id in order to signify that it's essentially the same patch. That way, when you search the change-id, you can easily all the branches it's applied to. Line 13: Bug-Url: https://bugzilla.redhat.com/1023145 -- To view, visit http://gerrit.ovirt.org/22937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a9a54b757d8aa5b5dc84ae02eae8114dfabc9f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
