Lior Vernia has posted comments on this change.
Change subject: webadmin: Add QoS widget to host network dialog
......................................................................
Patch Set 6:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
Line 395: getGateway().validateEntity(new IValidation[] { new
IpAddressValidation() });
Line 396: }
Line 397: }
Line 398:
Line 399: getQosModel().validate();
Yes, because when it's disabled its contained NetworkQosParametersModel objects
are disabled and are thus valid.
Line 400:
Line 401: return getNetwork().getIsValid() && getAddress().getIsValid()
&& getSubnet().getIsValid()
Line 402: && getGateway().getIsValid() &&
getQosModel().getIsValid();
Line 403: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQosWidget.java
Line 141:
this.model.getPropertyChangedEvent().removeListener(availabilityListener);
Line 142: }
Line 143: this.model = model;
Line 144:
model.getPropertyChangedEvent().addListener(availabilityListener);
Line 145: toggleVisibility();
Good idea, I contemplated it. Thought it would be better to encapsulate the
logic in the widget, as it might be useful in case it's used elsewhere.
Line 146: }
Line 147:
Line 148: @Override
Line 149: public BaseNetworkQosModel flush() {
--
To view, visit http://gerrit.ovirt.org/22809
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f622b23f86a8e19d373f2210e71804006e70c5f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
