Allon Mureinik has posted comments on this change. Change subject: core: db - prevent installing same script content twice ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (3 inline comments) Question: how do SKIPPED and CURRENT interact? should a SKIPPED script be allowed to be current? In addition, as far as I recall this is due to a real usecase - consider adding a BZ/patch number to the commit message so this info is clearer. Other than that, basically +1. .................................................... Commit Message Line 10: Example: s/datbase/database/ Line 19: s/after/later/ Line 23: s/insrure/ensure/ -- To view, visit http://gerrit.ovirt.org/4169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id41a4b9406a9e60de783f779c9a51e5de7ce7676 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
