Omer Frenkel has posted comments on this change.
Change subject: core: Hot set number of CPUs using update VM
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 216: AuditLogableBase logable = new AuditLogableBase();
Line 217: logable.setVmId(getVmId());
Line 218: logable.addCustomValue("numberOfCpus",
String.valueOf(getParameters().getVm().getNumOfCpus()));
Line 219: logable.addCustomValue("ErrorMessage",
returnValue.getExceptionString() + " "
Line 220: + returnValue.getVdsError().getMessage());
i think this should be translated with Backend.getInstance()
.getVdsErrorsTranslator()
Line 221:
Line 222: AuditLogDirector.log(logable, returnValue.getSucceeded() ?
Line 223: AuditLogType.SET_NUMBER_OF_CPUS :
AuditLogType.FAILED_SET_NUMBER_OF_CPUS);
Line 224:
--
To view, visit http://gerrit.ovirt.org/22757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464a3dda5f143d1fcef63fd903eb615b01efe081
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
