Dan Kenigsberg has posted comments on this change.

Change subject: [RFE] Use Management class to pass informations
......................................................................


Patch Set 2:

(1 comment)

....................................................
File src/engine_page.py
Line 350: 
Line 351:             mgmt = Management()
Line 352:             mgmt.update("oVirt Engine http://%s:%s"; % (cfg["server"],
Line 353:                                                        cfg["port"),
Line 354:                         ["ovirtmgmt"], # FIXME is this still created?
the management network should NOT be created if Engine is of version >=3.3. On 
those systems, Engine is expected to create the network on its own.
Line 355:                         None)
Line 356: 
Line 357:             msgConf = "{engine_name} Configuration Successfully " \
Line 358:                 " Updated".format(


-- 
To view, visit http://gerrit.ovirt.org/22375
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I441375ea4f7e18b55a7e4d8a7f661e067598de30
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to