Kobi Ianko has posted comments on this change.
Change subject: engine: Enable runOnce to choose a vnc keymap.
......................................................................
Patch Set 3:
(2 comments)
changed the getter/setter to getVm().getDynamicData().getVncKeyboardLayout()
as Roy suggested
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
Line 125: if (getParameters().getVncKeyboardLayout() == null) {
Line 126:
getVm().setVncKeyboardLayout(getVm().getDefaultVncKeyboardLayout());
Line 127: } else {
Line 128: // if is not null it means runVM was launch from the run
once command, thus
Line 129: // the VM can run with keyboard layout type which is
different from its default display type
yes, that is what I meant :)
I'll check the Rest issue, I think that because the VM parameters are not
saved at the DB it will be just fine
*checked - work good
Line 130:
getVm().setVncKeyboardLayout(getParameters().getVncKeyboardLayout());
Line 131: }
Line 132: }
Line 133:
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 496: }
Line 497: }
Line 498: if (vm.getDisplay().isSetKeyboardLayout()) {
Line 499: String vncKeyboardLayout =
vm.getDisplay().getKeyboardLayout();
Line 500: if (vncKeyboardLayout != null) {
Done
Line 501: params.setVncKeyboardLayout(vncKeyboardLayout);
Line 502: }
Line 503: }
Line 504: }
--
To view, visit http://gerrit.ovirt.org/22620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id908cbaca9f1b20b4b9868a87a8b21f318a493e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
