Mike Kolesnik has posted comments on this change.
Change subject: engine: Block nic labeling if network assigned to other
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java
Line 83:
Line 84: List<String> assignedNetworks =
validateNetworksNotAssignedToIncorrectNics();
Line 85: if (!assignedNetworks.isEmpty()) {
Line 86: return
failCanDoAction(VdcBllMessages.LABELED_NETWORK_ATTACHED_TO_WRONG_INTERFACE,
"$AssignedNetworks "
Line 87: + StringUtils.join(assignedNetworks.toArray(new
String[assignedNetworks.size()]), ", "));
There is a join method that accepts Collection that would make this code much
simpler..
Line 88: }
Line 89:
Line 90: return true;
Line 91: }
--
To view, visit http://gerrit.ovirt.org/23031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3d0b179ea1cdc1ed1e3c9901d8b4813130b9ce
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
