Alon Bar-Lev has posted comments on this change.
Change subject: tools: Adds notifier config validation prior to service startup
......................................................................
Patch Set 5:
(2 comments)
almost there, two last minor.
....................................................
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py
Line 190: ),
Line 191: )
Line 192:
Line 193: def _validateConfig(self):
Line 194: args = self._engineArgs + ['validate']
no need for temp variable
Line 195: self.logger.debug('Executing: %s', args)
Line 196: proc = subprocess.Popen(
Line 197: args=args,
Line 198: executable=self._executable,
Line 197: args=args,
Line 198: executable=self._executable,
Line 199: env=self._engineEnv,
Line 200: stdout=subprocess.PIPE,
Line 201: stderr=subprocess.PIPE,
please add: close_fds=True
Line 202: )
Line 203:
Line 204: stdout, stderr = proc.communicate()
Line 205:
--
To view, visit http://gerrit.ovirt.org/22629
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ad77a33697f254e60e1d0b12e343900e5b0b34
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
