Maor Lipchuk has posted comments on this change.
Change subject: core: update LUN device size using getVmStats
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDAODbFacadeImpl.java
Line 134: .addValue("serial", lun.getSerial())
Line 135: .addValue("lun_mapping", lun.getLunMapping())
Line 136: .addValue("vendor_id", lun.getVendorId())
Line 137: .addValue("product_id", lun.getProductId())
Line 138: .addValue("device_size", lun.getDeviceSize());
only a suggestion
Line 139: }
Line 140:
Line 141: @Override
Line 142: public MapSqlParameterMapper<LUNs> getBatchMapper() {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1008:
Line 1009: LUNs lunFromDB = ((LunDisk) disk).getLun();
Line 1010: LUNs lunFromMap = lunsMap.get(lunFromDB.getId());
Line 1011:
Line 1012: if (lunFromMap != null &&
lunFromMap.getDeviceSize() != 0
1. What I meant is when lunFromMap is null. It does not seems healthy, and
maybe it is worth to log about it (If that can happened)
2. cool, considering to add a todo here once when the patch 22976 is merged
Line 1013: && lunFromMap.getDeviceSize() !=
lunFromDB.getDeviceSize()) {
Line 1014: // Found a mismatch - set LUN for update
Line 1015: log.infoFormat("Updated LUN device size -
ID: {0}, previous size: {1}, new size: {2}.",
Line 1016: lunFromDB.getLUN_id(),
lunFromDB.getDeviceSize(), lunFromMap.getDeviceSize());
--
To view, visit http://gerrit.ovirt.org/22978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0d4d805ca333990ea1f612eb03a87f4a505f4a8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
