Oved Ourfali has submitted this change and it was merged. Change subject: core: findbugs: inconsistent synchronization ......................................................................
core: findbugs: inconsistent synchronization AsyncTasksManager is currently the only class with suffers from inconsistent synchronization. This patch does not solve those issues (in an attempt to "not rock the boat", but preserve the current situation). It does, however, move the exclusion of this check out of exclude-filters-general.xml and fine-grains it to exclude only AsyncTasksManager in order to avoid these potentially dangerous bugs in future classes. Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/exclude-filters.xml M exclude-filters-general.xml 2 files changed, 4 insertions(+), 10 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
