Oved Ourfali has posted comments on this change.
Change subject: engine: HA VM Reservation feature
......................................................................
Patch Set 3:
(2 comments)
In addition, some minor comments.
Once you address the findbugs warning, and the comments, you're free to go.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HaReservationBalancePolicyUnit.java
Line 23:
Line 24: /**
Line 25: * This balancing policy, is for use in cases the user selected HA
Reservation for its Cluster. The basic methodology
Line 26: * is: 1. get the optimal HA VMs for each VM assuming evenly spreded
across the cluster 2. calc the overUtiliaze as
Line 27: * (1)*user cunfigured threshold in percent. 3. randomly choose a VM
from a busy host to move to another more available
s/cunfigured/configured
Line 28: * host.
Line 29: */
Line 30: public class HaReservationBalancePolicyUnit extends PolicyUnitImpl {
Line 31:
Line 57:
Line 58:
Line 59: int optimalHaDistribution = (int) Math.ceil(((double)
haVmsInCluster / hosts.size()));
Line 60:
Line 61: int overUtilizationParam = 200;
Consider having this as a constant somewhere?
Line 62: if (parameters.get("OverUtilization") != null) {
Line 63: overUtilizationParam =
NumberUtils.toInt(parameters.get("OverUtilization"));
Line 64: } else {
Line 65: overUtilizationParam = Config.<Integer>
getValue(ConfigValues.OverUtilizationForHaReservation);
--
To view, visit http://gerrit.ovirt.org/22929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44e698e58ff5e4a0b74249d3fe3cf4acf042c324
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
