Martin Peřina has posted comments on this change.
Change subject: tools: Adds notifier config validation prior to service startup
......................................................................
Patch Set 9:
F19:
# systemctl start ovirt-engine-notifier
Job for ovirt-engine-notifier.service failed. See 'systemctl status
ovirt-engine-notifier.service' and 'journalctl -xn' for details.
# systemctl status ovirt-engine-notifier
ovirt-engine-notifier.service - oVirt Engine Notifier
Loaded: loaded (/usr/lib/systemd/system/ovirt-engine-notifier.service;
disabled)
Active: failed (Result: exit-code) since St 2014-01-08 13:13:32 CET; 4s ago
Process: 683
ExecStart=/usr/share/ovirt-engine/services/ovirt-engine-notifier/ovirt-engine-notifier.py
--redirect-output --systemd=notify $EXTRA_ARGS start (code=exited,
status=1/FAILURE)
led 08 13:13:31 mperina-ovirt1.localdomain systemd[1]: Starting oVirt Engine
Notifier...
led 08 13:13:32 mperina-ovirt1.localdomain ovirt-engine-notifier.py[683]:
Validation result:
led 08 13:13:32 mperina-ovirt1.localdomain ovirt-engine-notifier.py[683]:
stderr: Check configuration file, 'MAIL_SERVER' is missing
led 08 13:13:32 mperina-ovirt1.localdomain ovirt-engine-notifier.py[683]:
Validation failed returncode is 1:
led 08 13:13:32 mperina-ovirt1.localdomain ovirt-engine-no[683]: 2014-01-08
13:13:32,700 ovirt-engine-notifier: ERROR run:523 Error: Configuration is
invalid
led 08 13:13:32 mperina-ovirt1.localdomain systemd[1]:
ovirt-engine-notifier.service: main process exited, code=exited,
status=1/FAILURE
led 08 13:13:32 mperina-ovirt1.localdomain systemd[1]: Failed to start oVirt
Engine Notifier.
led 08 13:13:32 mperina-ovirt1.localdomain systemd[1]: Unit
ovirt-engine-notifier.service entered failed state.
RHEL6:
# service ovirt-engine-notifier start
Starting oVirt Engine Notifier:
Validation result:
stderr: Check configuration file, 'MAIL_SERVER' is missing
Validation failed returncode is 1:
[FAILED]
# service ovirt-engine-notifier status
ovirt-engine-notifier dead but pid file exists
--
To view, visit http://gerrit.ovirt.org/22629
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ad77a33697f254e60e1d0b12e343900e5b0b34
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches