Ori Liel has posted comments on this change.
Change subject: restapi: Return Additional Info For 400 Messages (#867794)
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/UsageFinder.java
Line 34: }
Line 35: return null; // should never happen
Line 36: }
Line 37:
Line 38: private RSDL getRSDL(Application application) {
I agree with this notion. I suggest that making RSDL stand-alone will be a
separated patch. Is it ok with you to merge this patch without this refactoring
(after I upload a new version with your corrections) and in another patch I
will crate the RsdlManager?
Line 39: for (Object obj : application.getSingletons()) {
Line 40: if (obj instanceof BackendApiResource) {
Line 41: BackendApiResource resource = (BackendApiResource) obj;
Line 42: return resource.getRSDL();
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
Line 249: applicationMode == ApplicationMode.GlusterOnly ?
ApiUtils.getGlusterRels(uriInfo)
Line 250: : ApiUtils.getAllRels(uriInfo);
Line 251: for (String path : paths) {
Line 252: Class<?> resource = findResource(path, classes);
Line 253: String entryPointPath = uriInfo.getBaseUri().getPath();
Right, I stand corrected.
Line 254: String prefix = entryPointPath.endsWith("/") ?
entryPointPath + path : entryPointPath + "/" + path;
Line 255: results.addAll(describe(resource, prefix, new
HashMap<String, Type>()));
Line 256: }
Line 257: return results;
--
To view, visit http://gerrit.ovirt.org/23017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7a6da4fbb00ea5f1e6919ddfe21dd7b3dd126fd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
