Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: services: remove pid when service start fails ......................................................................
packaging: services: remove pid when service start fails the service is running under non privileged user, so it cannot remove the pid file only clear it. if service is dead at validation stage its status is printed as: dead but pid file exists to remedy that, if service fails to start we remove the pid if service start fails and pid file is zero length. Related-To: https://bugzilla.redhat.com/989382 Change-Id: I8c5ff88aef181dbf4955bd976c176642290e13d0 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in M packaging/services/ovirt-engine/ovirt-engine.sysv.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/23066/1 diff --git a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in index b154df4..37e7f28 100644 --- a/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in +++ b/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in @@ -52,6 +52,7 @@ RETVAL=0 fi fi + [ $RETVAL -ne 0 -a ! -s "${PIDFILE}" ] && rm -f "${PIDFILE}" ;; stop) echo -n $"Stopping $PROG: " diff --git a/packaging/services/ovirt-engine/ovirt-engine.sysv.in b/packaging/services/ovirt-engine/ovirt-engine.sysv.in index 7cf7a08..26b6e0d 100644 --- a/packaging/services/ovirt-engine/ovirt-engine.sysv.in +++ b/packaging/services/ovirt-engine/ovirt-engine.sysv.in @@ -52,6 +52,7 @@ RETVAL=0 fi fi + [ $RETVAL -ne 0 -a ! -s "${PIDFILE}" ] && rm -f "${PIDFILE}" ;; stop) echo -n $"Stopping $PROG: " diff --git a/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in b/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in index a012330..db3627e 100644 --- a/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in +++ b/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in @@ -53,6 +53,7 @@ RETVAL=0 fi fi + [ $RETVAL -ne 0 -a ! -s "${PIDFILE}" ] && rm -f "${PIDFILE}" ;; stop) echo -n $"Stopping $PROG: " -- To view, visit http://gerrit.ovirt.org/23066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8c5ff88aef181dbf4955bd976c176642290e13d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
