Fabian Deutsch has posted comments on this change.
Change subject: Use Management class to pass informations
......................................................................
Patch Set 4:
(3 comments)
....................................................
File src/engine_page.py
Line 348: if write_vdsm_config(cfg["server"], cfg["port"]):
Line 349: self.logger.info("Starting vdsm-reg service")
Line 350: deployUtil._logExec([constants.EXT_SERVICE, 'vdsm-reg',
'start'])
Line 351:
Line 352: mgmtInterface = ""
mgmtInterface = None
Line 353: for iface in MGMT_IFACES:
Line 354: if os.path.exists('/sys/class/net/' + iface):
Line 355: mgmtInterface = iface
Line 356: break
Line 351:
Line 352: mgmtInterface = ""
Line 353: for iface in MGMT_IFACES:
Line 354: if os.path.exists('/sys/class/net/' + iface):
Line 355: mgmtInterface = iface
mgmtInterface = [iface]
Line 356: break
Line 357:
Line 358: mgmt = Management()
Line 359: mgmt.update("oVirt Engine http://%s:%s"; % (cfg["server"],
Line 358: mgmt = Management()
Line 359: mgmt.update("oVirt Engine http://%s:%s"; % (cfg["server"],
Line 360: cfg["port"]),
Line 361: [mgmtInterface],
Line 362: None)
Then we can do done here:
mgmt.update("oVirt Engine http://%s:%s"; % (cfg["server"],
cfg["port"]),
mgmtInterface,
None)
If mgmtInterface is None, then the key will not be written to the config file
and we will fallback to the default NIC on the system-.
Line 363:
Line 364: msgConf = "{engine_name} Configuration Successfully " \
Line 365: " Updated".format(
Line 366: engine_name=config.engine_name)
--
To view, visit http://gerrit.ovirt.org/22375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I441375ea4f7e18b55a7e4d8a7f661e067598de30
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
