Roy Golan has posted comments on this change.

Change subject: webadmin, core: Prevent arch mismatches in the FE
......................................................................


Patch Set 9:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsClusterEmptyQuery.java
Line 21:         if (cluster.getArchitecture() == ArchitectureType.undefined) {
Line 22:             getQueryReturnValue().setReturnValue(true);
Line 23:             return;
Line 24:         }
Line 25: 
combine these 2 in single stored procedure under VdsGroupDao
Line 26:         List<VdsStatic> allVdsForVdsGroup = 
getDbFacade().getVdsStaticDao().getAllForVdsGroup(cluster.getId());
Line 27: 
Line 28:         List<VM> allVmsForVdsGroup = 
getDbFacade().getVmDao().getAllForVdsGroup(cluster.getId());
Line 29: 


-- 
To view, visit http://gerrit.ovirt.org/19132
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0033c399061108c4495029ae2bca3f62e75fac68
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa 
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to