Yair Zaslavsky has posted comments on this change.
Change subject: backend: getLdapServers() use getCanonicalHostName
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
Line 485: }
Line 486:
Line 487: for (String host: argValue.split(DOMAIN_SEPERATOR)) {
Line 488: try {
Line 489: InetAddress.getByName(host).getCanonicalHostName();
I agree.
Line 490: } catch (UnknownHostException e) {
Line 491: String warnMessage = "Warning: Cannot resolve FQDN: "
+ e.getMessage();
Line 492: log.warn(warnMessage);
Line 493: System.out.println(warnMessage);
Line 492: log.warn(warnMessage);
Line 493: System.out.println(warnMessage);
Line 494: }
Line 495: }
Line 496: return new
ArrayList<String>(Arrays.asList(argValue.split(DOMAIN_SEPERATOR)));
+1 on Martin's comment.
Line 497: }
Line 498:
Line 499: public void addDomain(CLIParser parser) throws
ManageDomainsResult {
Line 500: String authMode = LdapAuthModeEnum.GSSAPI.name();
--
To view, visit http://gerrit.ovirt.org/19547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibae81ccd6b2a402c856934839f1dbdad316bbc3d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
