Piotr Kliczewski has posted comments on this change.
Change subject: engine: Json-rpc integration
......................................................................
Patch Set 12:
(4 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 192: int clientTimeOut = Config.<Integer>
getValue(ConfigValues.vdsTimeout) * 1000;
Line 193: int connectionTimeOut = Config.<Integer>
getValue(ConfigValues.vdsConnectionTimeout) * 1000;
Line 194: int clientRetries = Config.<Integer>
getValue(ConfigValues.vdsRetries);
Line 195:
Line 196: if (_vds.getPort() == 4044) {
Done
Line 197: _vdsProxy = new
JsonRpcVdsServer(JsonRpcUtils.createClient(_vds.getHostName(),
Line 198: _vds.getPort(), connectionTimeOut,
Line 199: clientTimeOut, clientRetries,
Line 200: Config.<Boolean>
getValue(ConfigValues.EncryptHostCommunication)));
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 543: int clientTimeOut = Config.<Integer>
getValue(ConfigValues.vdsTimeout) * 1000;
Line 544: int connectionTimeOut = Config.<Integer>
getValue(ConfigValues.vdsConnectionTimeout) * 1000;
Line 545: int clientRetries = Config.<Integer>
getValue(ConfigValues.vdsRetries);
Line 546:
Line 547: if (getmIrsPort() == 4044) {
Done
Line 548: privatemIrsProxy = new
JsonRpcIIrsServer(JsonRpcUtils.createClient(host,
Line 549: getmIrsPort(), connectionTimeOut,
Line 550: clientTimeOut, clientRetries,
Line 551: Config.<Boolean>
getValue(ConfigValues.EncryptHostCommunication)));
Line 1625: public EventResult call() {
Line 1626: return ResourceManager.getInstance()
Line 1627:
.getEventListener().masterDomainNotOperational(
Line 1628: masterDomainId,
getParameters().getStoragePoolId(), true,
Line 1629:
getVDSReturnValue().getVdsError() != null &&
Done
Line 1630:
getVDSReturnValue().getVdsError().getCode() ==
VdcBllErrors.StoragePoolWrongMaster);
Line 1631: }
Line 1632: });
Line 1633: } else {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 910: }
Line 911: parameters.setOverrideFirewall((Boolean)
model.getOverrideIpTables().getEntity());
Line 912: boolean protocol =
(Boolean)model.getTransportProtocol().getEntity();
Line 913: if (protocol) {
Line 914: host.setPort(4044);
Done
Line 915: }
Line 916: parameters.setTransportProtocol(protocol);
Line 917: parameters.setRebootAfterInstallation(isVirt);
Line 918: parameters.setAuthMethod(model.getAuthenticationMethod());
--
To view, visit http://gerrit.ovirt.org/20926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66ef0c98f07de6c447a5fffc42c9dbc94580df46
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
