Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: ScrollableTabBar
......................................................................
Patch Set 9:
(5 comments)
Thanks Alex for addressing all of my comments.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/ScrollableTabBarPresenterWidget.java
Line 86: resizeHandlerRegistration.removeHandler();
Line 87: }
Line 88: }
Line 89: }));
Line 90: resizeHandlerRegistration = Window.addResizeHandler(new
ResizeHandler() {
Thanks, this makes it clear to me.
So the Window.addResizeHandler is needed for the initial load, I assume there
is some delay between Window resize vs. splitter receiving its onResize
callback due to resize event bubbling from Window down to layout panels.
Line 91: @Override
Line 92: public void onResize(ResizeEvent resizeEvent) {
Line 93: getView().recalculateSize();
Line 94: getView().showScrollButtons();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
Line 138: }
Line 139:
Line 140: @Override
Line 141: public void addTabWidget(IsWidget tabWidget, int index) {
Line 142: Widget listWidget = copyWidget(tabWidget);
Yes, I was not criticizing :-) I was just interested. I'm OK with current
implementation.
Line 143: if (listWidget != null) {
Line 144: widgetBar.insert(tabWidget, index);
Line 145: dropdownPanel.insert(listWidget, index);
Line 146: }
Line 198: * Calculate the minimum width needed to display all the tabs on
the bar. This works even if there are some
Line 199: * right floating tabs.
Line 200: */
Line 201: private void recalculateWidgetBarMinWidth() {
Line 202: // Add 1 for browsers that don't report width properly.
I see, it doesn't seem like an issue to me, thanks for clarification.
Line 203:
widgetBar.getElement().getStyle().setProperty(MIN_WIDTH_STYLE,
calculateWidgetMinWidthNeeded() + 1, Unit.PX);
Line 204: }
Line 205:
Line 206: /**
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
Line 95: private final FlowPanel contentPanel;
Line 96:
Line 97: // List of action buttons managed by this action panel
Line 98: private final List<ActionButtonDefinition<T>> actionButtonList =
new ArrayList<ActionButtonDefinition<T>>();
Line 99: // List of buttons in the tool-bar.
OK, thanks for clarification.
Line 100: private final List<ActionButtonDefinition<T>>
actionToolbarButtonList = new ArrayList<ActionButtonDefinition<T>>();
Line 101:
Line 102: private final SearchableModelProvider<T, ?> dataProvider;
Line 103: private final EventBus eventBus;
Line 411: String styleString = ((Widget)
newActionButton).getStyleName();
Line 412: if (styleString != null) {
Line 413: String[] stylesArray = styleString.split(" ");
//$NON-NLS-1$
Line 414: for (String singleStyle : stylesArray) {
Line 415: if (!singleStyle.startsWith(GWT_PREFIX)) {
OK, I'm fine with current approach.
Line 416: cascadeButton.addStyleName(singleStyle);
Line 417: }
Line 418: }
Line 419: }
--
To view, visit http://gerrit.ovirt.org/21716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63dddb3c0026ea3a5c13c3d18daebd02e13b1043
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
