Vitor de Lima has posted comments on this change.
Change subject: core: NPE in update vm (via rest)
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 399: allDisks,
Line 400: isVirtioScsiEnabled(),
Line 401: hasWatchdog(),
Line 402: getParameters().isBalloonEnabled(),
Line 403:
Boolean.TRUE.equals(getParameters().isSoundDeviceEnabled()),
I think that if IsSoundDeviceEnabled() is null, it means that the user wants it
to stay the same way it was before the update. In this code, it considers null
as the same thing as false.
Line 404: getReturnValue().getCanDoActionMessages());
Line 405: }
Line 406:
Line 407: private boolean vmDeviceChanged(VmDeviceGeneralType deviceType,
boolean deviceEnabled) {
--
To view, visit http://gerrit.ovirt.org/23067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef9490664a663db1aaf2fa14da239df01d78bab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
