Gustavo Frederico Temple Pedrosa has posted comments on this change.
Change subject: core: fix virtio-scsi validation on update VM
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 427: deviceType, device);
Line 428:
Line 429: return deviceEnabled == vmDevices.isEmpty();
Line 430: }
Line 431:
This method is a great idea! Why don't put it into the VmDeviceUtils?
Line 432: private boolean isVmExist() {
Line 433: return getParameters().getVmStaticData() != null && getVm()
!= null;
Line 434: }
Line 435:
--
To view, visit http://gerrit.ovirt.org/23052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
