Michal Skrivanek has posted comments on this change.
Change subject: engine: Enable per-VM configuration of migration downtime
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1569: @DefaultValueAttribute("10")
Line 1570: MaxNumOfTriesToRunFailedAutoStartVm,
Line 1571:
Line 1572: @TypeConverterAttribute(Integer.class)
Line 1573: @DefaultValueAttribute("500")
I hate this whole file.
But anyway, default should be 0 if thats the vdsm default, I'd say...
Line 1574: DefaultMaximumMigrationDowntime,
Line 1575:
Line 1576: Invalid;
....................................................
File packaging/etc/engine-config/engine-config.properties
Line 353: SchedulerAllowOverBooking.description="Allowing skipping Scheduling
resource synchronization, which could result in overbooking"
Line 354: SchedulerAllowOverBooking.type=Boolean
Line 355: SchedulerOverBookingThreshold.description="Skip Scheduling resource
synchronization, which could result in overbooking, if there are more than X
requests pending for scheduling (in case SchedulerAllowOverBooking=true and
cluster is configured as allow overbooking)."
Line 356: SchedulerOverBookingThreshold.type=Integer
Line 357: DefaultMaximumMigrationDowntime.description="Maximum number of
milliseconds a live migration can take."
description is misleading, this is about max downtime, not wall time of whole
migration
Line 358: DefaultMaximumMigrationDowntime.type=Integer
Line 359: DefaultMaximumMigrationDowntime.validValues=0..2147483647
--
To view, visit http://gerrit.ovirt.org/22272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia16f66540497d20178efae6989710000110a81d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
